About
  • First commit 21 June 2011
  • Latest commit 22 May 2012
Last Week All Time
Commits: 6 33
Files changed: 9 32
Change in LOC: 180 614

Reviews

12 active reviews

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

sachiko is mapped to 1 committer over 1 repository
Username sachiko is mapped to:

sachiko

EarlieractivityNolateractivity
sachiko

changed the Assignee to 'sachiko' on OPENAM-1330

22 May
sachiko

created OPENAM-1330

22 May
sachiko

resolved OPENAM-1326

22 May
sachiko

changed the Assignee to 'sachiko' on OPENAM-1326

22 May
sachiko

summarized and closed CR-419

22 May
No summary.
sachiko

committed 2014 to openam

22 May
OPENAM-1326:: Deadlock in PeriodicRunnable
modified PeriodicRunnable.java
sachiko

committed 2013 to openam

22 May
OPENAM-1326:: Deadlock in PeriodicRunnable
modified PeriodicRunnable.java
sachiko

committed 2012 to openam

22 May
OPENAM-1326:: Deadlock in PeriodicRunnable
modified PeriodicRunnable.java
sachiko

commented on OPENAM-776

22 May
Thank you for your comment. We are planning to drop the use of Netscape LDAP SDK from openAM. If we are to fix this issue, then we should actually start using OpenDJ SDK, which by definition should comply with the RFC -> so these characters are always properly encoded in that version as well.

sachiko

committed 2002 to openam

21 May
OPENAM-1007:: Memory Leak in SMSNotificationManager when ldap error occurs
added to SpecialRepo.java and modified 7 java files
sachiko

changed the Assignee to 'Jonathan Scudder' on OPENAM-1206

21 May
reassigning to Jonathan while he's getting external opinion.

----
If users need to accept a license then we still need to take this into account during silent install. A quick check of practices for other products suggests that adding a flag or property along the lines of "IAcceptOpenAMTermsOfUse=true" could be a valid approach.

As to whether we need to ask for acceptance of a license, then we do at some point in the chain since this is where the user is granted permission to use the software. We may not need to ask so actively for acceptance though, or to ask at installation time.
----
sachiko

committed 2001 to openam

21 May
OPENAM-1007:: Memory Leak in SMSNotificationManager when ldap error occurs
added to 2 java files and modified 6 java files
sachiko

committed 2000 to openam

21 May
OPENAM-1007:: Memory Leak in SMSNotificationManager when ldap error occurs
added to SpecialRepo.java and modified 7 java files
sachiko

started review CR-419

21 May
OPENAM-1326: Deadlock in PeriodicRunnable (side effect of OPENSSO-5377)
sachiko

attached one file to OPENAM-1326

21 May
thisTurn and nextTurn locking should be independent from each other within PeriodicRunnable#removeElement()
OPENAM-1326.diff
sachiko

created OPENAM-1326

21 May
sachiko

finished reviewing CR-418

20 May
sachiko

commented on CR-418

20 May

Please update copyright section

sachiko

finished reviewing CR-415

17 May
sachiko

replied to Mark de Reeper in CR-415

17 May

The rule about copyright notice is as follows (got clarifications from Steve for other CR)

Square brackets are to be removed when you see them in the source code.
So the standard copyright line should be like this:

> * Portions Copyrighted 2012 ForgeRock Inc

Where a file already has a ForgeRock copyright notice; if it says ForgeRock AS it should be updated to read ForgeRock Inc and the year updated if required.

sachiko

added jonathan to review CR-411

16 May
sachiko

replied to Mark de Reeper in CR-411

16 May

sorry, I took diff against 9.5.2. will take diff against TRUNK in the next one.

sachiko

replied to Mark de Reeper in CR-411

16 May

thanks for pointing out about validserverconfig.properties file.
not sure about the naming convention. The package name for AdminTokenAction.java is still com.sun.identity so I thought it would make more sense to make the property name the same as package name? But will change the property name to suggested one in the new diff.

sachiko

replied to Mark de Reeper in CR-411

16 May

changed. thanks for pointing this out

sachiko

finished reviewing CR-414

13 May
sachiko

started review CR-411

09 May
OPENAM-1109: AdminTokenAction doesn't clear invalid SSOToken
sachiko

closed OPENAM-1218

06 May
sachiko

commented on OPENAM-1218

06 May
looking at the attached threadump, JVM is not showing sign of deadlock.
"tomcat-http--16" is waiting for LDAP bind request to return with a connection. Since this is not a deadlock and is probably to do with your LDAP performance which you may want to tune. Therefore, closing the bug as invalid.

"tomcat-http--16" daemon prio=10 tid=0x0000000047f6e800 nid=0x53b5 in Object.wait() [0x000000004275e000]
   java.lang.Thread.State: WAITING (on object monitor)
        at java.lang.Object.wait(Native Method)
        - waiting on <0x00002aaac4c69588> (a com.sun.identity.shared.ldap.LDAPResponseListener)
        at java.lang.Object.wait(Object.java:485)
        at com.sun.identity.shared.ldap.LDAPResponseListener.waitForMessage(LDAPResponseListener.java:183)
        at com.sun.identity.shared.ldap.LDAPResponseListener.waitFirstMessage(LDAPResponseListener.java:145)
        - locked <0x00002aaac4c69588> (a com.sun.identity.shared.ldap.LDAPResponseListener)
        at com.sun.identity.shared.ldap.LDAPConnection.sendRequest(LDAPConnection.java:1863)
        - locked <0x00002aaac053a200> (a com.sun.identity.shared.ldap.LDAPConnection)
        at com.sun.identity.shared.ldap.LDAPConnection.simpleBind(LDAPConnection.java:1827)
        at com.sun.identity.shared.ldap.LDAPConnection.restoreConnection(LDAPConnection.java:2001)
        at com.sun.identity.shared.ldap.LDAPConnection.checkConnection(LDAPConnection.java:1979)
        at com.sun.identity.shared.ldap.LDAPConnection.clone(LDAPConnection.java:5965)
        - locked <0x00002aaac053a200> (a com.sun.identity.shared.ldap.LDAPConnection)
        at com.sun.identity.common.LDAPConnectionPool.createConnection(LDAPConnectionPool.java:614)
        at com.sun.identity.common.LDAPConnectionPool.getConnFromPool(LDAPConnectionPool.java:418)
        at com.sun.identity.common.LDAPConnectionPool.getConnection(LDAPConnectionPool.java:392)
        - locked <0x00002aaac0539fe8> (a com.sun.identity.common.LDAPConnectionPool)
        at com.sun.identity.common.LDAPConnectionPool.getConnection(LDAPConnectionPool.java:349)
        at com.sun.identity.authentication.modules.ldap.LDAPAuthUtils.getAdminConnection(LDAPAuthUtils.java:494)
        at com.sun.identity.authentication.modules.ldap.LDAPAuthUtils.searchForUser(LDAPAuthUtils.java:768)
        at com.sun.identity.authentication.modules.ldap.LDAPAuthUtils.authenticateUser(LDAPAuthUtils.java:417)
        at com.sun.identity.idm.plugins.ldapv3.LDAPv3Repo.authenticateIt(LDAPv3Repo.java:5006)
        at com.sun.identity.idm.plugins.ldapv3.LDAPv3Repo.authenticate(LDAPv3Repo.java:4932)
        at com.sun.identity.idm.server.IdServicesImpl.authenticate(IdServicesImpl.java:322)
        at com.sun.identity.idm.AMIdentityRepository.authenticate(AMIdentityRepository.java:510)
        at com.sun.identity.authentication.modules.datastore.DataStore.process(DataStore.java:138)
        at com.sun.identity.authentication.spi.AMLoginModule.wrapProcess(AMLoginModule.java:916)
        at com.sun.identity.authentication.spi.AMLoginModule.login(AMLoginModule.java:1081)
sachiko

commented on OPENAM-1218

30 Apr
Hi, I confirmed the fix is checked into released version of OpenAM 9.5.4. Can you send us the full thread dump from your system because you might be encountering something different?
sachiko

replied to sachiko in CR-398

24 Apr

Hi,

The rule about copyright notice is as follows.

Square brackets are to be removed when you see them in the source code.
So the standard copyright line should be like this:

> * Portions Copyrighted 2012 ForgeRock Inc
> * Portions Copyrighted 2012 Open Source Solution Technology Corporation

Where a file already has a ForgeRock copyright notice; if it says ForgeRock AS it should be updated to read ForgeRock Inc and the year updated if required. In Tsukiguchi-san's case, please change ForgeRock copyright notice from "ForgeRock AS" to "ForgeRock Inc" as well.