isNewEntry() is set to true for SMSEntry's that had no attributes or is this the same as not being persisted? I think the less risk approach would be keep this block but follow the same pattern as...

isNewEntry() is set to true for SMSEntry's that had no attributes or is this the same as not being persisted?

I think the less risk approach would be keep this block but follow the same pattern as above, i.e. removing from cache and calling clear() on the result which will provide the same improvement around allowing the collection of ServiceConfigImpl instances.

Don't forget to update the year in header.

Don't forget to update the year in header.

Should this log message also be moved into the new if (profiles) block?

Should this log message also be moved into the new if (profiles) block?

Will correct this date.

Will correct this date.

Remembered overnight that these changes would also impact some JSP pages, updated to include JSPs that needed updating.

Remembered overnight that these changes would also impact some JSP pages, updated to include JSPs that needed updating.

Fix for OPENAM-6196 - don't call getOutputStream() when getWriter() has already been called on the response.
Fix for OPENAM-6196 - don't call getOutputStream() when getWriter() has already been called on the response.
Didn't mean to remove this doc item, have restored.

Didn't mean to remove this doc item, have restored.

Not expecting it to be used in the DAS but if it is then the DAS properties will also need updating.

Not expecting it to be used in the DAS but if it is then the DAS properties will also need updating.

OPENAM-5542 - improve the caching of ServiceConfigImpl instances
OPENAM-5542 - improve the caching of ServiceConfigImpl instances
  • More
  • CR-7898
  • summarized and closed
Apart from header, the change has reduced to just: "multipleMatches")); } // single user found.- AMIdentity amId = (AMIdentity)amIdSet.iterator().next(); ...

Apart from header, the change has reduced to just:

                 "multipleMatches"));
         }
         // single user found.
-        AMIdentity amId = (AMIdentity)amIdSet.iterator().next();
+        final AMIdentity amId = (AMIdentity)amIdSet.iterator().next();
+        final String universalId = IdUtils.getUniversalId(amId);
+
         if (debug.messageEnabled()) {
             debug.message("IdRepoDataStoreProvider.getUserID()"
                 + " Name=: " + amId.getName()
                 + " DN=: " + amId.getDN()
-                + " univId=: " + IdUtils.getUniversalId(amId));
+                + " univId=: " + universalId);
         }
-        return DNUtils.normalizeDN(IdUtils.getUniversalId(amId));
+
+        return universalId;
     }
  • More
  • CR-7990
  • summarized and closed
This works fine without the additional DNUtils work.

This works fine without the additional DNUtils work.

Fix for OPENAM-6642 - repeated calles to tokeninfo endpoint causes unnecessary number of ServiceConfigImpl objects
Fix for OPENAM-6642 - repeated calles to tokeninfo endpoint causes unnecessary number of ServiceConfigImpl objects
You added ROOT_REALM const so might as well use it for all places where "/" is used.

You added ROOT_REALM const so might as well use it for all places where "/" is used.

Don't forget to update the header date too http://sources.forgerock.org/static/mt0445/2static/images/wiki/icons/emoticons/smile.gif

Don't forget to update the header date too

The new scheme for headers seems to be to include it below the existing header rather than have it on its own:  * "Portions Copyrighted [year] [name of copyright owner]"  *  * $Id: AddSubConfigura...

The new scheme for headers seems to be to include it below the existing header rather than have it on its own:

 * "Portions Copyrighted [year] [name of copyright owner]"
 *
 * $Id: AddSubConfiguration.java,v 1.7 2008/06/25 05:42:17 qcheng Exp $
 *
 * Portions Copyrighted 2015 ForgeRock AS.
 */
Should this be realmName rather than "/"?

Should this be realmName rather than "/"?

I see that when I refactored the code for the OPENAM-2238 fix I managed to copy this bug from the original SP code, shame I didn't use the method from the IDP code! Good catch.

I see that when I refactored the code for the OPENAM-2238 fix I managed to copy this bug from the original SP code, shame I didn't use the method from the IDP code! Good catch.

It would have been nice to have had some comments in the general section to provide some context of this review.

It would have been nice to have had some comments in the general section to provide some context of this review.