Mareks Malnačs

Its like this (an example with am_agent_login and no response from a remote site): *do am_net_connect in main thread, which creates event loop and boots the watchdog thread which monitors the eve...

Its like this (an example with am_agent_login and no response from a remote site):

  • do am_net_connect in main thread, which creates event loop and boots the watchdog thread which monitors the event loop for timeout (in case there is no response or server is very slow - we need to get out of the event loop and release the resources);
  • am_net_connect fails and am_agent_login exits with am_net_diconnect + am_net_close (in main thread);
  • at the same time (or earlier/later, depending where it is atm) net_async_poll_timeout is reached too (event loop has timed out) and it does am_net_diconnect together with all the upper level callbacks for net_ops.


am_net_diconnect is called (and it is allowed to) multiple times. crash was within set_exit_event when am_net_close was already called close_event (which destroyed mutex) but event handle wasn't set to NULL - second am_net_disconnect freaked out.

the same here

the same here

yup, sorry. it should be *e = NULL; event is just another pointer.

yup, sorry. it should be *e = NULL; event is just another pointer.

libxml2 is not required. Also there is no need in that text re libstdc++ under "linux systems" para.

libxml2 is not required.

Also there is no need in that text re libstdc++ under "linux systems" para.

Plain Windows 2008 is not supported. Must have 2008 R2 or newer.

Plain Windows 2008 is not supported. Must have 2008 R2 or newer.

not required anymore.

not required anymore.

"-k" option is redundant (when used with apachectl)

"-k" option is redundant (when used with apachectl)

should we encourage users to skip (reading of) the license?

should we encourage users to skip (reading of) the license?

.so extension here.

.so extension here.

.so files are available only with dev- packages. the default is .so.10 or .so.1.0.0

.so files are available only with dev- packages. the default is .so.10 or .so.1.0.0

WPA4 does not require libxml2 anymore.

WPA4 does not require libxml2 anymore.

WPA4 does not need Java at all.

WPA4 does not need Java at all.

Candidate fix for OPENAM-6864
Candidate fix for OPENAM-6864
  • More
  • CR-8204
  • summarized and closed
ok

ok

We are searching for an <Exception> element (xml) whereas 3x did just "exception" string.

We are searching for an <Exception> element (xml) whereas 3x did just "exception" string.

once it reaches allocation failure, HEADER_ERROR state is set and num_headers is decremented back to the known-good value (i.e. the last good allocation). once there is a header_error, headers_com...

once it reaches allocation failure, HEADER_ERROR state is set and num_headers is decremented back to the known-good value (i.e. the last good allocation).

once there is a header_error, headers_complete_cb will take care of releasing all the memory.

lets see what is simpler - null check+memset or a combination of strcpy/strcat.

lets see what is simpler - null check+memset or a combination of strcpy/strcat.

there is a little change needed (both here and in header_field_cb) - when realloc is called for the first time (i.e. first arg is NULL), we need to zero out the resulting buffer as strcat might fre...

there is a little change needed (both here and in header_field_cb) - when realloc is called for the first time (i.e. first arg is NULL), we need to zero out the resulting buffer as strcat might freak out (on windows).

no, this is not the multiple header values - its the same header read in multiple chunks

no, this is not the multiple header values - its the same header read in multiple chunks

the problem with this is that we dont know whether webserver we are trying to connect to will require a client cert (and thus a key too) or not; we will discover that only inside a handshake

the problem with this is that we dont know whether webserver we are trying to connect to will require a client cert (and thus a key too) or not; we will discover that only inside a handshake

sure. just a sec... done.

sure. just a sec... done.

Not with OpenSSL, unfortunately.

Not with OpenSSL, unfortunately.

Its from Joyent

Its from Joyent

Fix WPA4 networking module to be able to handle (non-)keep-alive and proxy-loadbalancer environments
Fix WPA4 networking module to be able to handle (non-)keep-alive and proxy-loadbalancer environments

or combine them in one if statement

or combine them in one if statement

LGTM.

LGTM.