About
  • First commit 21 November 2007
  • Latest commit 21 May 2012
Last Week All Time
Commits: 3 602
Files changed: 1 8,457
Change in LOC: 53 128,492

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Ludovic Poitou is mapped to 4 committers over 3 repositories
Username ludo is mapped to:

Ludovic Poitou

EarlieractivityNolateractivity
Ludovic Poitou

commented on OPENDJ-504

23 May

Manuel,

I agree with you.
However, there should be 2 different behaviors of the matching rule : when strictly compliant with the international telephone number format and when accepting loose numbers.
When accepting loose numbers, I believe ignoring non digit is fine, but we might result in an error if the reduced string is empty.

One other thing that is not treated properly for example is +1 800 FLOWERS, which some expects to match with +1 800 356 9377.

Ludovic.

Ludovic Poitou

commented on OPENDJ-504

23 May

Hi Jeffrey,

OpenDJ offers some flexibility with regards to the TelephoneNumber syntax by default but can be configured to be strictly compliant with the RFC, which means the value must be "compliant with the internationally agreed format for representing international telephone numbers [E.123]."

If you enable the strict-format (using dsconfig or check the ds-cfg-strict-format attribute in the TelephoneNumber syntax in config/config.ldif), then the values with non numbers will be rejected, but also all values that do not start with the + since the "international telephone number representation expects the +1 for US numbers and +xx for the other countries.

Now the substring matching rule on telephone number will ignore all non digit characters from the filter, and in your case, 

(telephoneNumber=*userid*)
is translated in (telephoneNumber=*) which means any phone number.

I'm still not sure whether there is a bug or not with this, and if an empty substring should throw an error or be accepted as it is today.
I'll discuss with the architect of OpenDJ to see if we can reach some agreement on the subject.

Ludovic Poitou

resolved OPENDJ-487

21 May

Fixed in the trunk and b2.4.

Ludovic Poitou

committed 8012 to opendj

21 May
Fix OPENDJ-487: Normal acis under cn=config are not loaded at startup.
Backport to 2.4 branch
Forgot to remove unused import.
deleted from AciHandler.java
Ludovic Poitou

committed 8010 to opendj

21 May
Fix OPENDJ-487: Normal acis under cn=config are not loaded at startup.
Backport to 2.4 branch
Rather than using regular internal connection search, lets search directly in the config backend, as it's not yet registered as a workflow.
The method is similar to what is done for the subEntryManager and the groupManager.
modified AciHandler.java
Ludovic Poitou

committed 8009 to opendj

21 May
Fix OPENDJ-487: Normal acis under cn=config are not loaded at startup.
Rather than using regular internal connection search, lets search directly in the config backend, as it's not yet registered as a workflow.
The method is similar to what is done for the subEntryManager and the groupManager.
modified AciHandler.java
Ludovic Poitou

changed the Assignee to 'Mark Craig' on OPENDJ-503

21 May
Ludovic Poitou

resolved OPENDJ-60, OPENDJ-494

18 May
Ludovic Poitou

committed 7976 to opendj

10 May
Fix OPENDJ-494: dsreplication initialize reports negative percentage of completion
Use long instead of int to compute progress
modified Installer.java
Ludovic Poitou

created OPENDJ-494

10 May
Ludovic Poitou

resolved OPENDJ-493

10 May

Committed in trunk

Ludovic Poitou

committed 7975 to opendj

10 May
Fix OPENDJ-493: Error message when parsing Integer attribute with invalid value is incorrect.
Fixed error message, added unit tests for IntegerSyntax, fixed typo in comment.
added IntegerSyntaxTest.java and modified 2 java files
Ludovic Poitou

created OPENDJ-493, OPENDJ-487

10 May
Ludovic Poitou

closed OPENDJ-481

07 May

It's normal to get a referral exception when the base entry of a search is a referral object.
A continuation reference is only returned when a referral object is found while searching below the base object.
I'm closing this issue as not a defect.

Ludovic Poitou

resolved OPENDJ-476

04 May

Committed in trunk

Ludovic Poitou

committed 7939 to opendj

04 May
Fix OPENDJ-476: Manage Account fails with NPE if target DN does not exist
Fix precommit tests failure.
modified 2 java files
Ludovic Poitou

committed 7938 to opendj

04 May
Fix OPENDJ-476: Manage Account fails with NPE if target DN does not exist
Cleaned up error message that mentioned the server while the error was on the client side
modified 5 properties files
Ludovic Poitou

committed 7937 to opendj

04 May
Fix OPENDJ-476: Manage Account fails with NPE if target DN does not exist
The NPE was occurring parsing the MatchedDN because schema was not initialized.
modified ManageAccount.java
Ludovic Poitou

closed OPENDJ-478

04 May

The changeNumber in the EntryChangeNotificationResponseControl is not mandatory and we cannot compute it at the time the change is applied.
Therefore, the server never returns it. The client API sets a default value of -1 to indicate that it's not provided.

Ludovic Poitou

commented on OPENDJ-478

03 May

I don't believe this is a bug.
We do not support returning the External ChangeLog change number associated with the change. This is optional. Both the changelog and the EntryChangeNotification are unrelated and trying to tie them together may result in big performance impact.

The decoder defaults the value to -1 to indicate that it was not returned through the control.

Ludovic Poitou

started progress on OPENDJ-476

03 May
Ludovic Poitou

changed the Assignee to 'Ludovic Poitou' on OPENDJ-476

03 May
Ludovic Poitou

committed 7914 to opendj

23 Apr
Fix OPENDJ-469.
This last commit resolves issues with the Nightly tests.
modified 2 java files
Ludovic Poitou

committed 7896 to opendj

17 Apr
Now that validateSchema defaults to true in the LDIFImportConfig class, it must explicitely set to false in the ReplicationBackend.
The entries exposed there might not be schema compliant, which is ok, as the backend is only used for backup/restore.
added to ReplicationBackend.java
Ludovic Poitou

committed 7895 to opendj

17 Apr
Fix unit-tests after changing default validateSchema value to true in the LDIFImportConfig class.
added to TestCaseUtils.java and modified TestLDIFWriter.java
Ludovic Poitou

resolved OPENDJ-472

17 Apr

Moved counter increment within the call to log to skipped or rejected.

Ludovic Poitou

committed 7894 to opendj

17 Apr
Fix OPENDJ-472: offline import LDIF reject entries, doesn't report the correct count of them, and store them in both rejected and skipped files.
Clean up and moved counters increments in call to log rejected or skipped entries.
modified LDIFReader.java
Ludovic Poitou

committed 7893 to opendj

17 Apr
Fix OPENDJ-469 - LDIFReader has code duplication and suffer from poor performance with highly multi-valued attributes.
Previous commit demonstrates an issue with the LDIFImportConfig, the validateSchema flag was not set in constructor.
added to LDIFImportConfig.java
Ludovic Poitou

created OPENDJ-472

17 Apr
Ludovic Poitou

committed 7892 to opendj

17 Apr
Fix OPENDJ-469 - LDIFReader has code duplication and suffer from poor performance with highly multi-valued attributes.
Another optimization to avoid double checking of the presence of an entry.
modified LDIFReader.java