Laszlo

Laszlo

finished reviewing CR-400

24 Apr
Laszlo

The updated header should be:

/*
 * The contents of this file are subject to the terms of the Common Development and
 * Distribution License (the License). You may not use this file except in compliance with the
 * License.
 *
 * You can obtain a copy of the License at legal/CDDLv1.0.txt. See the License for the
 * specific language governing permission and limitations under the License.
 *
 * When distributing Covered Software, include this CDDL Header Notice in each file and include
 * the License file at legal/CDDLv1.0.txt. If applicable, add the following below the CDDL
 * Header, with the fields enclosed by brackets [] replaced by your own identifying
 * information: "Portions Copyrighted [year] [name of copyright owner]".
 *
 * Copyright © 2011-2012 ForgeRock. All rights reserved.
 */
 
Laszlo

started review CR-392

09 Apr
Laszlo

replied to andi in CR-387

26 Mar

There are multiple consideration to decide how to map this functionality to an URL. Previously there was a strong opinion to address the sync engine to execute the live sync operation and then it turned to discovery engine. I'm in favour to have the discovery engine and define URL to perform action on another URL. This URL conforms this tendency and does not build wrong presumption for the future functionality.

The discovery engine and the URL schema is another topic for discussion.

Laszlo

started review CR-387

25 Mar
Allow calling of live sync via router
Laszlo

finished reviewing CR-381

23 Mar
Laszlo

finished reviewing CR-386

23 Mar
Laszlo

The pom.xml may patch the wrong pom. You intend to change the openidm-repo-orientdb/pom.xml and it's applied on parent pom.

Laszlo

This change generates an invalid pom syntax!

Laszlo

The JsonResourceObjectSet is Deprecated. Can we omit this class?