Default Project CR-8399

OPENAM-6422 / AME-8615 Improve Authentication chain UI

Closed on 07 Oct 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed

CR-8399 36

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 1h 45m 24 ok
Reviewer - 85% reviewed 15m    
Reviewer - 2% reviewed 0m    
Reviewer - 14% reviewed 6m    
Reviewer - 0% reviewed      
Reviewer - Complete 40m 9 I don't think we should use quotes when they're not neces...
Reviewer - 95% reviewed 10m 2 newLink = !self.data.linkConfig
Reviewer - 2% reviewed 1m 1 I agree with Eugenia's suggestion.
Total   2h 57m 36  
#permalink

Objectives

Some subtask left to do:
1: Disable delete button on default chains.
2: Re-add the accessibility keyboard controls - https://dev.opera.com/articles/accessible-drag-and-drop/
3: Separate the save button so it is no longer shared between tabs

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

There are no general comments on this review.
/a/openam/.../chains/CriteriaView.js Deleted  
Open in IDE #permalink
/a/openam/.../chains/EditChainView.js Changed   13
Open in IDE #permalink
/a/openam/.../chains/EditLinkView.js Changed   1
Open in IDE #permalink
/a/openam/.../chains/LinkInfoView.js Deleted  
Open in IDE #permalink
/a/openam/.../chains/LinkView.js Changed   1
Open in IDE #permalink
/a/openam/.../chains/PostProcessView.js Changed   1
Open in IDE #permalink
/a/openam/.../authentication/ChainsView.js Changed   3
Open in IDE #permalink
/a/openam/.../css/am-admin/console.less Changed  
Open in IDE #permalink
/a/openam/.../resources/css/styles-admin.less Changed  
Open in IDE #permalink
/a/openam/.../locales/en/translation.json Changed  
Open in IDE #permalink
/a/openam/.../chains/CriteriaTemplate.html Deleted  
Open in IDE #permalink
/a/openam/.../chains/EditChainTemplate.html Changed  
Open in IDE #permalink
/a/openam/.../chains/LinkInfoTemplate.html Deleted  
Open in IDE #permalink
/a/openam/.../chains/LinkTemplate.html Changed  
Open in IDE #permalink
/b/openam/.../css/am-admin/chains.less Added   1
Open in IDE #permalink
/b/openam/.../partials/alerts/_Alert.html Added   1
Open in IDE #permalink
/b/openam/.../chains/PopoverTemplate.html Added  
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.10.47.png Added 1
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.11.18.png Added 1
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.11.34.png Added 1
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.12.06.png Added 7
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.13.07.png Added 2
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.13.19.png Added
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.13.28.png Added
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.13.40.png Added
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.13.49.png Added 2
Open in IDE #permalink
/Screen Shot 2015-10-06 at 16.15.07.png Added 1
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against