Default Project CR-8377

Windows 32bit agent builds

Closed on 07 Oct 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed

CR-8377 2

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 15m 1 Ok. This patch does not provide (and was not intended to)...
Reviewer - Complete 5m    
Reviewer - Complete 19m 1 Yes, this will build the windows 32 bit agents, however, ...
Total   39m 2  
#permalink

Objectives

This patch adds an option to build 32 and 64 bit agents/utilities on Windows.

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

05 Oct 15

Charles Sparey says:

Yes, this will build the windows 32 bit agents, however, I am not convinced that it will work in the IIS case whereby agents are installed into both 32 and 64 bit thread pools. The issue we have there is the way the memory is organized within the cache tables. In order for this to work, compound types such as size_t need to be removed and replaced with fixed length variable types that are consistent across 32 and 64 bit compilation architectures. In addition, we will need to be very careful with the way we store the various pointer offsets. We will need to ensure that they are fixed to a 32 bit value and that all data fits or is allocated into this space.

05 Oct 15

Mareks Malnačs says:

Ok. This patch does not provide (and was not intended to) an option to load both types at the same time or within the same IIS server. That fix is coming at a later date.

/source/admin.c Changed  
Open in IDE #permalink
/source/admin_iis.c Changed  
Open in IDE #permalink
/source/property_map.c Changed  
Open in IDE #permalink
/source/thread.c Changed  
Open in IDE #permalink
/source/utility.c Changed  
Open in IDE #permalink
/Makefile Changed  
Open in IDE #permalink
/Makefile.windows.mk Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against