Default Project CR-8366

Fix for OPENAM-6537 - treat logout URIs/parameters as not enforced

Closed on 03 Nov 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed

CR-8366 12

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 38m 8 Updated review with reworked fix, original fix was overly...
Reviewer - Complete 31m 4 Looks good.
Total   1h 10m 12  
#permalink

Objectives

As per the bug report, when a URI has been set in the com.sun.identity.agents.config.agent.logout.url property, the URI should treated as not-enforced to avoid sending the user to authenticate if they hit the URI without a session, only to then trigger a logout.

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

28 Oct 15

markdr says:

Updated review with reworked fix, original fix was overly complicated and did not take into account the logout parameter property.

02 Nov 15

Peter Major says:

Looks good.

/jee-agents/.../filter/AmFilterHandlerBase.java Changed   3
Open in IDE #permalink
/jee-agents/.../filter/ApplicationLogoutHandler.java Changed  
Open in IDE #permalink
/jee-agents/.../filter/LogoutHelper.java Changed   1
Open in IDE #permalink
/jee-agents/.../filter/NotenforcedListTaskHandler.java Changed   5
Open in IDE #permalink
/jee-agents/.../arch/ServiceResolver.java Changed  
Open in IDE #permalink
/jee-agents/.../filter/LogoutHelper.java Changed  
Open in IDE #permalink
/jee-agents/.../filter/SSOTaskHandler.java Changed   1
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against