Default Project CR-8185

Change property file line endings on non-windows systems.

Closed on 14 Sep 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed

CR-8185 1

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 15m 1 e->value is already checked, so NOTNULL is not used here.
Reviewer - Complete 7m    
Reviewer - Complete 2m    
Total   24m 1  
#permalink

Objectives

Simple patch to generate property file with \n line endings on non windows systems, leaving them as \r\n on windows.

This is linked to OPENAM-6820 but unable to link it in crucible.

Second attempt: fix problem of buffer not being initially null terminated in property_map_write_to_buffer.
Third attempt: added change to agent.conf.template replacing c-type comment with #.

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

There are no general comments on this review.
/config/agent.conf.template Changed  
Open in IDE #permalink
/source/property_map.c Changed   1
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against