Default Project CR-8150

Preserve local property file formatting.

Closed on 14 Sep 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed
    • Reviewer completed

CR-8150 28

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 1h 2m 11 Okay, will check in. Thanks
Reviewer - Complete 49m 2 Same comment as above.
Reviewer - Complete 49m 15 You can ignore my comment - there is no issue there. We a...
Reviewer - Complete 4m    
Total   2h 44m 28  
#permalink

Objectives

This change will preserve the formatting in property files, including in the agents 4 template file.
The installer dialog is changed so that during upgrade, previous values cannot be changed (except that the password must be provided again).

NOTE: this has conflicts in the installer with the SSL patch currently under review.

Iteration 2: Separates bootstrap bootstrap properties and adds comments to agent 4 config template. Also minor change to trimming in whitespace lines in properties file.

Latest iteration to fix problem with strndup returning a null pointer for an empty string, and to add some null pointer checks to the property map.
The change test_utility would crash on windows and solaris without this fix.

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

08 Sep 15

Mareks Malnačs says:

LGTM.

10 Sep 15

Mareks Malnačs says:

This version also looks OK to me.

/config/agent.conf.template Changed   7
Open in IDE #permalink
/source/admin.c Changed  
Open in IDE #permalink
/source/property_map.c Changed   9
Open in IDE #permalink
/source/utility.h Changed  
Open in IDE #permalink
/tests/test_utility.c Changed  
Open in IDE #permalink
/source/property_map.c Changed   1
Open in IDE #permalink
/source/utility.c Changed   9
Open in IDE #permalink
/tests/test_utility.c Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against