Default Project CR-8090

OPENAM-2749: Circle of Trust name is invalid : / when importing a remote entity in a subrealm

Closed on 08 Sep 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed

CR-8090 2

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 7m 1 I copied "in realm" from the property value of "addCOTFai...
Reviewer - Complete 2m    
Reviewer - Complete 3m 1 just out of curiosity, how did you figure out what the me...
Total   12m 2  
#permalink

Objectives

  • Problem
    OPENAM-2749 <https://bugster.forgerock.org/jira/browse/OPENAM-2749>
    Circle of Trust name is invalid : / when importing a remote entity in a subrealm

  • Reproduction Scenario
    1. Create an extended meta data file with invalid "cotlist" attribute values.
    2. Execute the command:
    ./ssoadm import-entity --adminid amadmin --password-file password.txt --realm / --meta-data-file STD_SP.xml --extended-data-file EXT_SP.xml
    

    -> COTException is recorded in debug/Fedration.

    com.sun.identity.cot.COTException: Circle of Trust name is invalid : /
    

    "/" is not a Circle of Trust name but a realm name. It is confusing.
    This wrong message also can be recorded in some SAML cases other than ssoadm command.

  • Analysis
    The message of "invalidCOTName" has only one placeholder, but two parameters (realm , name) are given.

  • Solution
    Add a placeholder to the message in properties files.

  • Install/Upgrade
    N/A

  • Performance
    N/A

  • I18N
    All languages

  • Testing
    (a) validating the fix solves the problem manually
    Check if the correct message is recorded in the debug log:
    com.sun.identity.cot.COTException: Circle of Trust name in realm / is invalid : XXXXX
    

  • Documentation
    N/A

  • Checkins
    openam-federation/openam-federation-library/src/main/resources/de_DE/libCOT_de.properties
    openam-federation/openam-federation-library/src/main/resources/es_ES/libCOT_es.properties
    openam-federation/openam-federation-library/src/main/resources/fr_FR/libCOT_fr.properties
    openam-federation/openam-federation-library/src/main/resources/ja_JP/libCOT_ja.properties
    openam-federation/openam-federation-library/src/main/resources/ko_KR/libCOT_ko.properties
    openam-federation/openam-federation-library/src/main/resources/libCOT.properties
    openam-federation/openam-federation-library/src/main/resources/zh_CN/libCOT_zh.properties
    openam-federation/openam-federation-library/src/main/resources/zh_TW/libCOT_zh_TW.properties

  • Diff
    Attached to CR
#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

08 Sep 15

sachiko says:

just out of curiosity, how did you figure out what the message should be in each language?

08 Sep 15

Kohei Tamura says:

I copied "in realm" from the property value of "addCOTFailed" in the same properties file.

/openam-federation/.../de_DE/libCOT_de.properties Changed  
Open in IDE #permalink
/openam-federation/.../es_ES/libCOT_es.properties Changed  
Open in IDE #permalink
/openam-federation/.../fr_FR/libCOT_fr.properties Changed  
Open in IDE #permalink
/openam-federation/.../ja_JP/libCOT_ja.properties Changed  
Open in IDE #permalink
/openam-federation/.../ko_KR/libCOT_ko.properties Changed  
Open in IDE #permalink
/openam-federation/.../zh_CN/libCOT_zh.properties Changed  
Open in IDE #permalink
/openam-federation/.../zh_TW/libCOT_zh_TW.properties Changed  
Open in IDE #permalink
/openam-federation/.../resources/libCOT.properties Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against