Default Project CR-7990

Fix for OPENAM-6642 - repeated calles to tokeninfo endpoint causes unnecessary number of...

Closed on 25 Aug 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed

CR-7990 2

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 16m    
Reviewer - Complete 10m    
Reviewer - Complete 25m 2 Looks sensible.
Total   50m 2  
#permalink

Objectives

When querying an OAuth2 access token via the tokeninfo endpoint, the Scope plugin class is looked up by querying the OAuth2 config and in OpenAM 11.0.x, this can result in creating a new instance of ServiceConfigImpl on every call rather than reusing a cached copy of the config.

This fix is based on a community provided patch to reuse the cached config. Some minor refactoring was carried out at the same. This issue does not effect OpenAM 12+ due to the refactoring of the OAuth2 components in 12.

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

21 Aug 15

jonthomas says:

Looks sensible.

/openam-oauth2/.../utils/OAuth2Utils.java Changed 1
Open in IDE #permalink
/openam-oauth2/.../provider/ValidationServerResource.java Changed
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against