Default Project CR-7944

OPENAM-6532 Unable to add a Rest STS instance with a value of "/" in the --subconfigname/-g option...

Closed on 27 Sep 15

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed

CR-7944 15

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 31m 6 Even if it will be technically correct, the "/" are not a...
Reviewer - Complete 30m 3 You added ROOT_REALM const so might as well use it for al...
Reviewer - Complete 13m 1 it's not too important, but you can probably define forwa...
Reviewer - 50% reviewed 2m    
Reviewer - 100% reviewed 1h 7m 5 extra space
Total   2h 24m 15  
#permalink

Objectives

There are no specific objectives for this review.
#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

19 Aug 15

jonthomas says:

Is the need to escape the / char in subconfigname a bug or existing functionality looks like the escape code check has been there for a while - if it is existing functionality do we want to keep ability to unescape for backwards compatibility just in case it is present in deployment scripts - granted this may be overkill.
Must admit can't see it documented.

19 Aug 15

Quentin CASTEL says:

The code

        if (subConfigName.startsWith(subRealmWithSlash)) {


allows the backwards compatibility with escape "/" in real name, so it should be fine

19 Aug 15

Quentin CASTEL says:

Actually you're right:

I need to call

 SMSSchema.unescapeName 

for each config component.

Would be

        for (int i = 0; i < subConfs.length; i++) {
            subConfs[i] = SMSSchema.unescapeName(subConfs[i]);
        }

( I will post a new diff)

/openam/.../schema/AddSubConfiguration.java Changed   5
Open in IDE #permalink
/openam/.../schema/DeleteSubConfiguration.java Changed  
Open in IDE #permalink
/openam/.../schema/ModifySubConfiguration.java Changed   2
Open in IDE #permalink
/openam/.../schema/SchemaCommand.java Changed   5
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against