Default Project CR-364

OPENAM-1057: Enhance upgradechecker

Under Review for 2 months (due 2 months ago)

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
 

CR-364 2

  • Expand all
  • Collapse all
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 16m 1 Good point, I will update it shortly.
Reviewer - 100% complete 13m 1 Looks great,but for future generations perhaps some javadoc ...
Total   30m 2  
#permalink

Objectives

It became a bit complicated, but I have 18 successful testcases proving this works.

#permalink

General Comments

28 Feb

steve says:

Looks great,but for future generations perhaps some javadoc around the method to describe the valid version string format defines in the reg ex?

28 Feb

Peter Major says:

Good point, I will update it shortly.

/a/opensso/.../upgrade/UpgradeUtils.java Changed
Open in IDE
#permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

 

Create Issue

X
Assign To Me
 

Log time against