Default Project CR-2974

OPENAM-3618 httpOnly cookie support for Java EE agents

Closed on 19 Feb 14

  •  
  •  
  •  
  •  
  • Author & Moderator
  • Reviewers
    • Reviewer completed
    • Reviewer completed

CR-2974 13

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator 9m 4 will update this one to if (cookie.isSecure() || CookieUt...
Reviewer - Complete 47m 4 Fair enough.
Reviewer - Complete 17m 5 It's not related to the current review, but it should not...
Total   1h 13m 13  
#permalink

Objectives

Lots of refactoring, at the end of the day I couldn't find any more plain response.addCookie invocations.

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

09 Feb 14

markdr says:

The update for CookieUtils will also solve OPENAM-3234.

10 Feb 14

bthalmayr says:

Would it make sense to refactor OpenAM core and DistAuth as well to reduce code duplication?

10 Feb 14

bthalmayr says:

OpenDJ code makes extensive usage of 'final' keyword ... should we encourage its usage as well?

10 Feb 14

Peter Major says:

In general, yes it is preferred wherever possible, not sure how this fits into the current review. Most of the code in the fields around the agent code can be turned to final, but this was not the purpose of this changeset.

10 Feb 14

bthalmayr says:

It's not related to the current review, but it should not be forgotten ... how can it be tracked?

/a/openam/.../shared/encode/CookieUtils.java Changed   6
Open in IDE #permalink
/a/.../common/CookieResetHelper.java Changed  
Open in IDE #permalink
/a/.../common/SSOTokenValidator.java Changed  
Open in IDE #permalink
/a/.../filter/AmFilterRequestContext.java Changed   1
Open in IDE #permalink
/a/.../filter/AttributeTaskHandler.java Changed  
Open in IDE #permalink
/a/openam-agents/.../filter/CDSSOContext.java Changed  
Open in IDE #permalink
/a/.../filter/CDSSOResultTaskHandler.java Changed  
Open in IDE #permalink
/a/.../filter/CDSSOTaskHandler.java Changed  
Open in IDE #permalink
/a/.../filter/CDSSOURLPolicyTaskHandler.java Changed  
Open in IDE #permalink
/a/.../filter/InitialPDPTaskHandler.java Changed  
Open in IDE #permalink
/a/.../filter/RedirectCheckResultHandler.java Changed  
Open in IDE #permalink
/a/openam-agents/.../filter/SSOContext.java Changed   1
Open in IDE #permalink
/a/.../filter/SSOTaskHandler.java Changed  
Open in IDE #permalink
/a/openam-agents/.../util/CookieUtils.java Deleted  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against