#permalink
Details
Warning: no files are visible, they have all been filtered.
| Participant | Role | Time Spent | Comments | Latest Comment |
|---|---|---|---|---|
| Author & Moderator | 18m | 2 | added another patch, this time it sets only "OK" in response... | |
| Reviewer - 50% complete | 4m | |||
| Reviewer - 50% complete | 15m | 1 | Looks ok to me but I am not familiar with the code. As this ... | |
| Reviewer - 50% complete | 3m | |||
| Reviewer - 0% complete | 1m | 1 | Before we go much further into patches, I think we should st... | |
| Total | 42m | 4 |
- Files: 2
#permalink
General Comments
07 Apr 11
mareks says:
yes, it affects only notifications - instead of just closing client connection we are responding with http200 and the closing. that is all this change does.
21 Apr 11
Peter Major says:
Before we go much further into patches, I think we should stop and have a think what the hell should we do about these notifications. Please read the following thread and let's discuss this first:
http://lists.forgerock.org/pipermail/openam-dev/2011-April/000144.html
|
/patch_SGN-377426.diff
Added
|
|---|
|
/patch_SGN-377426_1.diff
Added
|
|---|
Looks ok to me but I am not familiar with the code. As this affects only notifications then I suppose the chance of unintended behaviour is small?