•  
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix checkstyle
SearchFilter.java:

Used Collection.contains().

LDAPURL.java:

Simplified equals().

Use Collection.contains()

Used early exits

Removed duplicated code

CommonSchemaElements.java:

Changed getNormalizedNames() to return a Set instead of Iterable.

*.java:

Consequence of the change to CommonSchemaElements.getNormalizedNames().

Used early exits.

Extracted method SchemaElementPanel.getAliases().

VerifyIndex.java:

In mainVerifyIndex():

- use Collection.contains()

- release the shared lock in a finally clause

Remove duplicated code
Fix build (Eclipse did not give me any errors :( )
Use Collection.contains()
Use Collection.contains()
Code cleanup

Entry.java:

In applyModification(), extracted methods applyModificationToObjectclass() and applyModificationToNonObjectclass().

In hasUserAttribute() and hasOperationalAttribute(), extracted method hasAttribute()

Used Attribute.isReal() to explicit code + merged if statements.

Attribute.java:

Added isReal() -> !isVirtual().

AbstractAttribute.java:

Implemented isReal().

In equals() extracted method valuesEqual().

In hasAllOptions() and optionsEqual(), extracted method hasAllOptions0().

OPENDJ-1666 Code cleanup

* org.opends.server.protocols.http.HttpConnectionHandler

** Fix copyright section

** Make code more readable

*** Reformat

*** Inline some local variables

* org.opends.server.protocols.http.HTTPClientConnection

** Fix copyright section

** Reformat

* org.opends.server.protocols.http.CollectClientConnectionsFilter

** Fix copyright

* org.opends.server.protocols.http.CollectClientConnectionsFilterTest

** Reformat

AutoRefactor'ed Modification.java
AssuredReplicationPluginTest.java:

Used ReplicationTestCase.waitForSpecificMsg*().

Code cleanup

ReplicationTestCase.java:

In waitForSpecificMsgs() and calling methods, let exceptions go up.

EntryHistorical.java:

Use HistAttrModificationKey instead of raw string.

Code cleanup

Try to fix randomly failing test.

JmxTestCase.java:

In getJmxConnectionHandler(), increase maximum wait time from 6s to 10s.

JmxPrivilegeTestCase.java:

Extracted methods assertSuccess()

Code cleanup

HistAttrModificationKey.java:

Renamed DELATTR to ATTRDEL to match string representation.

Reverted part of r12768
Test code cleanup

NamingConflictTest.java

Extracted fields to simplify code in test methods.

Extracted methods setUpLocal(), tearDown(), addMsg(), modDnMsg(), replayMsg(), createAndAddEntry(), createParentEntry(), createChildEntry().

ModifyConflictTest.java:

Made the code a bit more readable.

AttrHistoricalSingle.java:

Extracted methods replaceOrDelete(), add(), replace(), delete() and deleteWithoutDeleteTime() to increase code expressiveness.

AssuredReplicationPluginTest.java:

Used ReplicationTestCase.waitForSpecificMsg() and waitForSpecificMsgs() to ignore unrelated messages.

ReplicationTestCase.java:

Added methods:

- waitForSpecificMsgs(Session session, Class<?>... msgTypes)

- waitForSpecificMsgs(ReplicationBroker broker, Class<?>... msgTypes)

Changed

<T extends ReplicationMsg> T waitForSpecificMsg(Session session, ReplicationBroker broker, Class<T> msgType)

to

ReplicationMsg waitForSpecificMsgs(Session session, ReplicationBroker broker, Class<?>... msgTypes)

HistoricalAttributeValueTestCase.java:

Added test values.

AttrHistoricalMultiple.java, AttrValueHistorical.java:

Improved toString()

Fix random test failure.

Tests methods were not properly isolated. The sequence testUpdateDeletedIDs() followed by testUpdateAddedIDs() caused the following failure:

17:42:32 T E S T F A I L U R E ! ! !

17:42:32

17:42:32 Failed Test: org.opends.server.backends.pluggable.DefaultIndexTest#testUpdateAddedIDs

17:42:32 Failure Cause: java.lang.AssertionError:

17:42:32 Expecting:

17:42:32 <[]>

17:42:32 to contain:

17:42:32 <[1, 2, 3, 4]>

17:42:32 but could not find:

17:42:32 <[1, 2, 3, 4]>

17:42:32

17:42:32 org.opends.server.backends.pluggable.Utils.assertIdsEquals(Utils.java:39)

17:42:32 org.opends.server.backends.pluggable.Utils.assertIdsEquals(Utils.java:51)

17:42:32 org.opends.server.backends.pluggable.DefaultIndexTest.testUpdateAddedIDs(DefaultIndexTest.java:76)

DefaultIndexTest.java:

In setUp(), use @BeforeMethod annotation (rather than @BeforeTest)

CR-8001 OPENDJ-2216 Add upgrade task which reruns dsjavaproperties
RebuildIndexTask.java:

Removed indexExists, used Collection.contains() instead

Add missing method in LdapPromiseWrapper

* opendj.ldap.spi.LdapPromiseWrapper

** The method was missing since the Promise API has been changed in fru-2.0.0-SNAPSHOT

Fix OPENDJ-2243: Missing ".bat" extension for bat/addrate script

Rename "opendj-ldap-toolkit/src/main/assembly/bat/addrate" to "opendj-ldap-toolkit/src/main/assembly/bat/addrate.bat"

AttrHistoricalSingleTest.java:

Fixed a bug in replay_deleteMissingAttributeValue().

Renamed replayOperationSuccess() to replayOperation().

Renamed replayOperationFailure() to replayOperationSuppressMod().

OPENDJ-1192 Modify request replay failures

Added unit tests for AttrHistoricalSingleT and AttrHistoricalMultiple.

Renamed AttrInfoTest to AttrHistoricalMultipleTest.